Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In gradle build, properly do npm install for client #324

Open
n8kim1 opened this issue Jan 28, 2021 · 0 comments
Open

In gradle build, properly do npm install for client #324

n8kim1 opened this issue Jan 28, 2021 · 0 comments

Comments

@n8kim1
Copy link
Contributor

n8kim1 commented Jan 28, 2021

In gradle builds: if new packages are introduced in the visualizer, we can sometimes fail to install them, and so things fail to run/build.

To install npm packages for the client: you need to run npm install-all in the top level directory, as stated by the client readme and package.json. This cd's into each of the two big subfolders, and properly does install. (otoh, npm install performs default behavior -- it tries to install everything in the wrapper that is the top directory, which is not quite what we want here)

Unforunately, in https://github.com/battlecode/battlecode21/blob/master/build.gradle#L243 --
commandLine 'npm', 'install'
This should really be install-all

@n8kim1 n8kim1 changed the title sadfkjasf;dkljdfa Properly install npm during client build Jan 28, 2021
@n8kim1 n8kim1 changed the title Properly install npm during client build In gradle build, properly do npm install for client Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant