Long press (hold) of button to add favorites doesn't work unless controller is remapped every time.

[monohydroxy]

Concerned project

Batocera

Distribution Version

Batocera V40

Architecture

Batocera Linux (X86/64)

Issue description

When viewing the game list for any system a long press of the North controller button (Xbox 360 Y button) does not add the game to the favorite list. When the button is released the Save Game state list appears. The same behavior is seen with the South button to open the options. Long pressing 'Enter' on a keyboard will bring up the game options list as expected. Also if I remap the controller buttons (to exactly the same as before) the very next long press will work. Subsequent long presses don't work after the remapping. I can remap then add one game to my favorite list, then I have to remap again.

Logs and data

Let me know what logs could be useful.

[dfilskov]

I can't repro this on Steam Deck but I did have something like that temporarily on RP5. Now it works.

Could holding North to add/remove favorites be a depricated behaviour?

I have found that in System Settings/Frontend Developer Options you can get "the old" reliable way to add / remove favorites back via game options. The feature is called Access Game Options with Norht Button.

(I don't think long-press should be used to anything actually as I'm against building delays into UIs)

[dfilskov]

Do you have Switch Confirm & Cancel Buttons in ES turned on inside System Settings / Frontend Developer Options?

I think that messes up the hold to ... behaviour.

[monohydroxy]

The "Switch Confirm & Cancel" option is turned off. I'll try the "Access Game Options with North Button". That will let me run without a keyboard, which is my main goal.
This is definitely an issue with controllers. If I hold 'Enter' on a keyboard I get the game options. If I hold South on the controller the game starts (even if I hold it for seconds).