Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sabnzbd Stats Support #494

Closed
fmunteanu opened this issue Aug 5, 2022 · 16 comments · Fixed by #555 · May be fixed by #661
Closed

Sabnzbd Stats Support #494

fmunteanu opened this issue Aug 5, 2022 · 16 comments · Fixed by #555 · May be fixed by #661

Comments

@fmunteanu
Copy link
Contributor

Thank you for the great and simple product, do you plan adding support for Sabnzbd Stats?

@ochompsky
Copy link

ochompsky commented Aug 9, 2022

No, if you want crap like that get Heimdall. We don't need to add bloat to this.

@SkilledAlpaca
Copy link

It would be nice to be able to see these stats as well.

SABnzbd does have API documentation that may prove useful if it's to be implemented.

No, if you want crap like that get Heimdall. We don't need to add bloat to this.

qBittorrent has this kind of integration. It would be logical to have the same kind of functionality for another popular download client as well.

image

mbentley added a commit to mbentley/homer that referenced this issue Nov 19, 2022
mbentley added a commit to mbentley/homer that referenced this issue Nov 19, 2022
@mbentley
Copy link
Contributor

I just added a PR for SABnzbd support to show the number of slots occupied (number of downloads).

@mbentley
Copy link
Contributor

I'd add more metrics but I figured that I could start with some the basics as just a simple download queue number was easy enough. More data could be scraped, probably without too much trouble but I am not great as CSS formatting so that might be a bit harder for me.

@fmunteanu
Copy link
Contributor Author

fmunteanu commented Nov 19, 2022

Nice job, thank you for the quick fix! Download queue is a very good start. @bastienwirtz can you please merge the PR?

@mbentley
Copy link
Contributor

mbentley commented Nov 19, 2022

I also just added another change to add an optional interval to update the value after looking at the qTorrent custom service. I might be able to re-use some code from the qTorrent example to get the download speed from SABnzbd but I might not be able to get to that until next week.

I also might try to add update intervals for a few other custom services as well as it was really straight forward.

bastienwirtz pushed a commit that referenced this issue Nov 19, 2022
* Adds SABnzbd custom service; fixes #494
@fmunteanu
Copy link
Contributor Author

@bastienwirtz when do you plan to release the new version, including the merged changes?

@bastienwirtz
Copy link
Owner

You got it @fmunteanu :) https://github.com/bastienwirtz/homer/releases/tag/v22.11.2

@fmunteanu
Copy link
Contributor Author

fmunteanu commented Dec 2, 2022

@mbentley thank you for the beautiful work. I installed the v22.11.2 and everything works as expected. Do you have any planned improvements?

@mbentley
Copy link
Contributor

mbentley commented Dec 2, 2022

I had been messing around with a few things locally, such as getting the download speed but I was struggling with where exactly to put it. The nice thing is that you get quite a bit of useful information from the same API call. My question would be what information, outside of download speed, may be useful, if anything.

@fmunteanu
Copy link
Contributor Author

fmunteanu commented Dec 2, 2022

You plan to add it under the name, I presume, like qBittorrent? I think is enough, it will be uniform with other tools. I like that you have the number of downloads into upper right corner, like the rest of tools.

@mbentley
Copy link
Contributor

mbentley commented Dec 2, 2022

Yeah, that would be the most likely location. I hadn't taken the time to look at what anything else was doing outside of qBittorrent though.

@fmunteanu
Copy link
Contributor Author

If you just copy the qBittorrent style, it would be easy to implement, I think. Anything else might be overkill, number of downloads and speed is perfect.

@1337Reaper
Copy link

I was really hoping Homer would offer these types of "at a glance" details such as download speed, how much is in queue, etc, so it could be a viable alternative to Heimdall.

@mbentley
Copy link
Contributor

I was playing with this a bit this morning and I am not sure about implementing it the same way as qBittorrent. At least for me, I have text under each service. I am not sure if @bastienwirtz would be OK with an implementation like this but it's fairly basic to be able to put the speed in another corner like this:

4 colums:
screenshot 2023-06-24 at 10 29 12 AM

3 columns:
screenshot 2023-06-24 at 10 28 46 AM

I was also thinking of adding a config option to disable the speed:

rateDisabled: true

Which then it would just look as it is today:
screenshot 2023-06-24 at 10 33 15 AM

@mbentley
Copy link
Contributor

I created #661 for at least getting feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants