validator: retries on 5xx & 429's #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return retry.Do2(ctx, retryAttempts, retry.Exponential(), func() (int, storage.BlobSidecars, error) { | ||
| status, resp, err := endpoint.FetchSidecars(id, format) | ||
|
|
||
| if err == nil && status != http.StatusOK && shouldRetry(status) { |
There was a problem hiding this comment.
should you retry on (certain) errors as well? I can see occasional connectivity issues causing errors to be returned.
There was a problem hiding this comment.
I believe this will retry when endpoint.FetchSidecars returns a error (due to a connectivity issue). In that case err != nil, and it'll just fall through to return the original error (which triggers the retry).
Adding this if statement, just ensures that err is set (and will trigger a retry) when the status code is a 5xx or 429.
If you think it's cleaner, we could change this to:
if shouldRetry(status) { return 0, BlobSidecars{}, errors.New(...) }
There was a problem hiding this comment.
ah I see, no it's fine as is, should have taken a bit more time to understand what was going on.
roberto-bayardo
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Occasionally fetching blobs can fail due to internal server errors, this detects a handful of status codes that we consider retry able for validation.