From 3d828204696b58ae65c49ff16431e9e3c5722818 Mon Sep 17 00:00:00 2001 From: Ben Parizek Date: Fri, 24 May 2024 08:57:51 -0400 Subject: [PATCH] Updates existing migration to address read-only scenario --- CHANGELOG/CHANGELOG-META.md | 6 ++++++ CHANGELOG/CHANGELOG-REDIRECTS.md | 6 ++++++ CHANGELOG/CHANGELOG-SENT-EMAIL.md | 6 ++++++ CHANGELOG/CHANGELOG-SITEMAPS.md | 6 ++++++ CHANGELOG/CHANGELOG-TRANSACTIONAL.md | 6 ++++++ .../migrations/m211101_000000_run_install_migration.php | 2 +- .../migrations/m211101_000000_run_install_migration.php | 2 +- .../migrations/m211101_000000_run_install_migration.php | 2 +- .../migrations/m211101_000000_run_install_migration.php | 2 +- .../migrations/m211101_000000_run_install_migration.php | 2 +- .../migrations/m211101_000000_run_install_migration.php | 2 +- 11 files changed, 36 insertions(+), 6 deletions(-) diff --git a/CHANGELOG/CHANGELOG-META.md b/CHANGELOG/CHANGELOG-META.md index 83a6918e..ae32b29e 100644 --- a/CHANGELOG/CHANGELOG-META.md +++ b/CHANGELOG/CHANGELOG-META.md @@ -1,5 +1,11 @@ # Changelog +## 4.2.5 - 2024-05-24 + +### Fixed + +- Fixed migration issue when read-only mode enabled + ## 4.2.4 - 2024-05-18 ### Added diff --git a/CHANGELOG/CHANGELOG-REDIRECTS.md b/CHANGELOG/CHANGELOG-REDIRECTS.md index fe0bc6aa..5903d199 100644 --- a/CHANGELOG/CHANGELOG-REDIRECTS.md +++ b/CHANGELOG/CHANGELOG-REDIRECTS.md @@ -1,5 +1,11 @@ # Changelog +## 4.2.5 - 2024-05-24 + +### Fixed + +- Fixed migration issue when read-only mode enabled + ## 4.2.4 - 2024-05-18 ### Added diff --git a/CHANGELOG/CHANGELOG-SENT-EMAIL.md b/CHANGELOG/CHANGELOG-SENT-EMAIL.md index 4647f1e2..08a26d76 100644 --- a/CHANGELOG/CHANGELOG-SENT-EMAIL.md +++ b/CHANGELOG/CHANGELOG-SENT-EMAIL.md @@ -1,5 +1,11 @@ # Changelog +## 4.2.5 - 2024-05-24 + +### Fixed + +- Fixed migration issue when read-only mode enabled + ## 4.2.4 - 2024-05-18 ### Fixed diff --git a/CHANGELOG/CHANGELOG-SITEMAPS.md b/CHANGELOG/CHANGELOG-SITEMAPS.md index 66ded37d..20ccb406 100644 --- a/CHANGELOG/CHANGELOG-SITEMAPS.md +++ b/CHANGELOG/CHANGELOG-SITEMAPS.md @@ -1,5 +1,11 @@ # Changelog +## 4.2.5 - 2024-05-24 + +### Fixed + +- Fixed migration issue when read-only mode enabled + ## 4.2.5 - 2024-05-18 ### Fixed diff --git a/CHANGELOG/CHANGELOG-TRANSACTIONAL.md b/CHANGELOG/CHANGELOG-TRANSACTIONAL.md index 39f642e4..5ef0eed2 100644 --- a/CHANGELOG/CHANGELOG-TRANSACTIONAL.md +++ b/CHANGELOG/CHANGELOG-TRANSACTIONAL.md @@ -1,5 +1,11 @@ # Changelog +## 4.2.5 - 2024-05-24 + +### Fixed + +- Fixed migration issue when read-only mode enabled + ## 4.2.4 - 2024-05-18 ### Fixed diff --git a/src/forms/migrations/m211101_000000_run_install_migration.php b/src/forms/migrations/m211101_000000_run_install_migration.php index ed138989..0a96b1f5 100644 --- a/src/forms/migrations/m211101_000000_run_install_migration.php +++ b/src/forms/migrations/m211101_000000_run_install_migration.php @@ -57,7 +57,7 @@ public function safeUp(): void $keyExists = Craft::$app->getProjectConfig()->get($moduleSettingsKey); - if ($keyExists) { + if (!$keyExists) { // @todo - fix default settings to import Craft::$app->getProjectConfig()->set($moduleSettingsKey, [ 'defaultSidebarTab' => 'submissions', diff --git a/src/meta/migrations/m211101_000000_run_install_migration.php b/src/meta/migrations/m211101_000000_run_install_migration.php index 7d599aed..f888b01c 100644 --- a/src/meta/migrations/m211101_000000_run_install_migration.php +++ b/src/meta/migrations/m211101_000000_run_install_migration.php @@ -33,7 +33,7 @@ public function safeUp(): void $keyExists = Craft::$app->getProjectConfig()->get($moduleSettingsKey); - if ($keyExists) { + if (!$keyExists) { Craft::$app->getProjectConfig()->set($moduleSettingsKey, [ 'renderMetadata' => true, 'maxMetaDescriptionLength' => 160, diff --git a/src/redirects/migrations/m211101_000000_run_install_migration.php b/src/redirects/migrations/m211101_000000_run_install_migration.php index c948c5d7..635705f1 100644 --- a/src/redirects/migrations/m211101_000000_run_install_migration.php +++ b/src/redirects/migrations/m211101_000000_run_install_migration.php @@ -35,7 +35,7 @@ public function safeUp(): void $keyExists = Craft::$app->getProjectConfig()->get($moduleSettingsKey); - if ($keyExists) { + if (!$keyExists) { Craft::$app->getProjectConfig()->set($moduleSettingsKey, [ 'matchDefinition' => self::URL_WITHOUT_QUERY_STRINGS, 'queryStringStrategy' => self::REMOVE_QUERY_STRINGS, diff --git a/src/sentemail/migrations/m211101_000000_run_install_migration.php b/src/sentemail/migrations/m211101_000000_run_install_migration.php index b191716a..6e9e2fd9 100644 --- a/src/sentemail/migrations/m211101_000000_run_install_migration.php +++ b/src/sentemail/migrations/m211101_000000_run_install_migration.php @@ -23,7 +23,7 @@ public function safeUp(): void $keyExists = Craft::$app->getProjectConfig()->get($moduleSettingsKey); - if ($keyExists) { + if (!$keyExists) { Craft::$app->getProjectConfig()->set($moduleSettingsKey, [ 'sentEmailsLimit' => 2500, 'cleanupProbability' => 1000, diff --git a/src/sitemaps/migrations/m211101_000000_run_install_migration.php b/src/sitemaps/migrations/m211101_000000_run_install_migration.php index 2a2feb17..2ea2706d 100644 --- a/src/sitemaps/migrations/m211101_000000_run_install_migration.php +++ b/src/sitemaps/migrations/m211101_000000_run_install_migration.php @@ -26,7 +26,7 @@ public function safeUp(): void $keyExists = Craft::$app->getProjectConfig()->get($moduleSettingsKey); - if ($keyExists) { + if (!$keyExists) { Craft::$app->getProjectConfig()->set($moduleSettingsKey, [ 'enableContentQuerySitemaps' => false, 'enableCustomPagesSitemap' => false, diff --git a/src/transactional/migrations/m211101_000000_run_install_migration.php b/src/transactional/migrations/m211101_000000_run_install_migration.php index 446c6936..dfa814e3 100644 --- a/src/transactional/migrations/m211101_000000_run_install_migration.php +++ b/src/transactional/migrations/m211101_000000_run_install_migration.php @@ -45,7 +45,7 @@ public function safeUp(): void $keyExists = Craft::$app->getProjectConfig()->get($coreModuleSettingsKey); - if ($keyExists) { + if (!$keyExists) { Craft::$app->getProjectConfig()->set($coreModuleSettingsKey, [ 'enabled' => true, ]);