Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any plans to start working on upgrading to v5? #8

Open
thecodejack opened this issue Jun 12, 2021 · 23 comments
Open

Any plans to start working on upgrading to v5? #8

thecodejack opened this issue Jun 12, 2021 · 23 comments

Comments

@thecodejack
Copy link

This is very interesting project. Just wanted to check if you have any plans to start looking into v5 support of material ui?
@bareynol
Copy link
Owner

I do, along with some general UX upgrades. Unfortunately, that likely won't land on my plate until MUI v5 exits the pre-release stage.

@baharalidurrani
Copy link

I hope the current v4 variant will still be around as a lot of app maintainers won't be able to migrate to v5 in the near future.

@guldskog
Copy link

@bareynol Any updates on this?

@bareynol
Copy link
Owner

bareynol commented Sep 24, 2021 via email

@LuckeeDev
Copy link

Hey there @bareynol! Is there any way we can get involved with the development of the new version? Do you need any help?

@medoror
Copy link

medoror commented Oct 11, 2021

Ditto with @LuckeeDev would love to support. Great job so far by the way!

@tobtrie
Copy link

tobtrie commented Oct 25, 2021

@bareynol Is there any update on this?

@bareynol
Copy link
Owner

bareynol commented Oct 25, 2021 via email

@LuckeeDev
Copy link

@bareynol count me in!

@jamiehaywood
Copy link

@bareynol just discovered your site, would love to help with the V5 upgrade as well 😊

@jason-lex
Copy link

Been using MUI v5 as well. Wondering if there is any timeframe on when it ill be available?...

@drecali
Copy link

drecali commented Jan 26, 2022

@bareynol
I just discovered this impressive tool! Thanks for making it!
I'm also interested in helping with the v5 support as well. I have some colleagues that might be able to pitch in too. It'd be really cool if the MUI team could devote some resources to it or have something similar. It makes for a fantastic UX, especially for people that are new to MUI. Thanks again!

@Zenoo
Copy link

Zenoo commented Feb 17, 2022

I would also be up for helping, if you still need it.
I'll open a PR with the project migrated to MUI V5 if you want.

@bertearazvan
Copy link

This tool is purely awesome! 🚀

@Zenoo
Copy link

Zenoo commented Apr 7, 2022

The PR #12 added support for MUI v5.
@bareynol doesn't seem to be active anymore, so in the meantime, the new version is available from my fork on https://zenoo.github.io/mui-theme-creator/

@lolero
Copy link

lolero commented Apr 13, 2022

The PR #12 added support for MUI v5. @bareynol doesn't seem to be active anymore, so in the meantime, the new version is available from my fork on https://zenoo.github.io/mui-theme-creator/

Thanks for forking this amazing tool and upgrading it to MUI v5!!

I tried the app at https://zenoo.github.io/mui-theme-creator/ but when I change the default and paper background colors, the background no longer changes when I flip the light/dark switch.

And I tried checking out https://github.com/Zenoo/mui-theme-creator to run it locally but when I run yarn start, I get this error: ModuleNotFoundError: Module not found: Error: Can't resolve 'src/components/SavedThemes/DefaultThemes'

Any idea why flipping the background with the theme type or why running the code locally doesn't work?

@Zenoo
Copy link

Zenoo commented Apr 13, 2022

@lolero That's the usual behavior, even on the main theme creator.
As soon as you customize a color, it stays like this, light or dark theme in place.
You can reset your color though.

I can't say for sure why you can't run the code on your end, everything seems fine on mine

@lolero
Copy link

lolero commented Apr 13, 2022

@lolero That's the usual behavior, even on the main theme creator. As soon as you customize a color, it stays like this, light or dark theme in place. You can reset your color though.

I can't say for sure why you can't run the code on your end, everything seems fine on mine

Thanks for the quick reply!

Is there a way to set colors for the background and the text so that they change when the type param on the theme toggles between light and dark?

@Zenoo
Copy link

Zenoo commented Apr 13, 2022

You can define two themes (which is the way themes work in MUI too, you switch from one to the other).
Set everything you want in your first theme, save it in the Saved themes tab, then create your second one and save it too.
You can now switch between them.

@gitname gitname mentioned this issue Aug 17, 2022
Open
@Ou7law007
Copy link

Ou7law007 commented Sep 9, 2022 •
edited
Loading

@Zenoo Snippets don't work. Thanks though

@Zenoo
Copy link

Zenoo commented Sep 9, 2022

@Ou7law007 They work for me, can you open an issue on my fork describing your issue?

@RaviGuggilam
Copy link

RaviGuggilam commented Oct 17, 2022 •
edited
Loading

unable to add below values to ThemeOptions as it is not in the key in Interface

props: {
MuiTooltip: {
arrow: true,
},
},

below is working
components: {
MuiTooltip: {
defaultProps: { arrow: true },
},
},

@etherx-dev
Copy link

The PR #12 added support for MUI v5. @bareynol doesn't seem to be active anymore, so in the meantime, the new version is available from my fork on https://zenoo.github.io/mui-theme-creator/

the real MVP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests