Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Uncontrolled sample rate changes with downsampling #100

Open
m-nishim0t0 opened this issue Jul 16, 2024 · 1 comment
Open

[BUG] Uncontrolled sample rate changes with downsampling #100

m-nishim0t0 opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@m-nishim0t0
Copy link

Need to address downsampling issue with logLira in unitFilt.

@m-nishim0t0 m-nishim0t0 added the bug Something isn't working label Jul 16, 2024
@Nabarb Nabarb assigned Nabarb and FrancescoNegri and unassigned Nabarb and m053m716 Jul 17, 2024
@FrancescoNegri
Copy link
Member

When running doUnitFilter, each channel goes through the following steps:

  1. Stimulus artifacts rejection (optional)
  2. Filtering
  3. Downsampling (optional)

If downsampling is enabled, the Block.SampleRate is modified after the first processed channel and the subsequent channels believe that new frequency is their original sample rate. This causes isssues in the conversion of stimulus onsets from time to samples and also in the filtering step, when setting the filter characteristics.

@FrancescoNegri FrancescoNegri changed the title Downsampling issues [BUG] Downsampling issues Jul 17, 2024
@FrancescoNegri FrancescoNegri changed the title [BUG] Downsampling issues [BUG] Uncontrolled sample rate changes with downsampling Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants