Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement diff check #2

Open
sagikazarmark opened this issue Jun 18, 2019 · 4 comments
Open

Implement diff check #2

sagikazarmark opened this issue Jun 18, 2019 · 4 comments

Comments

@sagikazarmark
Copy link
Member

Instead of always applying a configuration, calculate diff using the objectmatcher library.

@icereed
Copy link

icereed commented Jun 28, 2019

Maybe we can take a look at https://get-kapp.io/ because they have a quite nice desired state and diff calculation. It would be good to know, whether this is easily transferable.

@danxmoran
Copy link

@sagikazarmark is this under development on your end? I'd be happy to try contributing it (either using objectmatcher or kapp), but I don't want to duplicate efforts

@sagikazarmark
Copy link
Member Author

@danxmoran it's on my todolist, but not a top priority, so feel free to give it a try if you want.

For now, I would prefer using objectmatcher, but @icereed thanks for the link, we will definitely take a look at it.

@kim0
Copy link

kim0 commented Sep 25, 2019

Hi @sagikazarmark

I'm not really sure how this provider is supposed to work. But what I'm see'ing is not matching my expectations:

  • I apply a horizontalpodautoscaler (hpa) through this provider
  • I use kubectl edit hpa foo and change some things manually
  • I then run terraform again, but it does not detect that anything changed. And does not re-apply blindly.

Should I open a separate bug ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants