Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(defect_dojo): parametrize cmdb #282

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

feat(defect_dojo): parametrize cmdb #282

wants to merge 3 commits into from
+781 −90

Conversation

MikeHV14
Copy link
Collaborator

@MikeHV14 MikeHV14 commented Dec 26, 2024 •
edited
Loading

Description

Adjustment is made by parameterizing what is necessary to consume the cmdb regardless of the endpoint

Checklist:

  • The pull request is complete according to the guide of contributing of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Gaviria9601
Gaviria9601 reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Gaviria9601 Gaviria9601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review the comments.

example_remote_config_local/engine_core/ConfigTool.json Show resolved Hide resolved
...ecops_engine_tools/engine_core/src/infrastructure/driven_adapters/defect_dojo/defect_dojo.py Outdated Show resolved Hide resolved
...ecops_engine_tools/engine_core/src/infrastructure/driven_adapters/defect_dojo/defect_dojo.py Outdated Show resolved Hide resolved
.../devsecops_engine_tools/engine_utilities/defect_dojo/infraestructure/driver_adapters/cmdb.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
89.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gaviria9601 Gaviria9601 Gaviria9601 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeHV14 @Gaviria9601