Add fix command #152
Merged
Add fix command #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@byshy please pull changes |
|
Done |
|
As a quick note, before publishing the changes to pub get, we should run the dart formatter on the changed files (in this PR and the 3 before) since I have custom rules on my IDE to set the length of the dart line to 130, it should be 80, so we should run that then publish |
santitigaga
requested changes
Nov 6, 2024
- Add jsonReportPath to the fix command - Add unit test to the fix command
|
Notes handled, I'm available for new notes if any 🙏 |
…st instead of firstOrNull to be picked by the linter
santitigaga
approved these changes
Nov 7, 2024
|
Amazing!! |
|
@byshy yes of course, https://linkedin.com/in/santiago-garcia-gil-742b38252/ |
|
Invitation sent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the analyze command, I added a fix command that utilizes the replacement defined inside each rule to automatically replace the fixes
You can run the command on the example/lib and it will identify the 3 issues it has in the
main.dartfile, and fix only 1 (which has the replacement defined)