Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefer first or null rule #150

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

byshy
Copy link
Contributor

@byshy byshy commented Nov 4, 2024

This PR has changes from this PR, please make sure to review that first

What's new?

  • Adding a new rule that prefers the use of firstOrNull instead of first on iterables and its derivatives

@santitigaga
Copy link
Contributor

@byshy Amazing, this is a useful rule.
Please add this new rule in the documentation in the gh-pages-source branch

@santitigaga santitigaga added awaiting info Improvement New feature or request labels Nov 5, 2024
@byshy
Copy link
Contributor Author

byshy commented Nov 6, 2024

I handled the comments above
I'm thinking about adding all the rules at once to the gh-pages-source, is that okay? or do you prefer to add them now?

@santitigaga
Copy link
Contributor

I handled the comments above I'm thinking about adding all the rules at once to the gh-pages-source, is that okay? or do you prefer to add them now?

it's ok add all rules in one PR

Copy link
Contributor

@santitigaga santitigaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing !!!

@santitigaga santitigaga merged commit a2e90be into bancolombia:trunk Nov 6, 2024
1 check passed
@byshy byshy deleted the prefer_first_or_null branch November 8, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting info Improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants