Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included directories being deployed even if no changes to contents #374

Open
coatesap opened this issue Oct 17, 2019 · 2 comments
Open

Included directories being deployed even if no changes to contents #374

coatesap opened this issue Oct 17, 2019 · 2 comments

Comments

@coatesap
Copy link

coatesap commented Oct 17, 2019

This issue was originally raised in #306 and seems to have been addressed in #313. However, as of today, it appears that the contents of included directories are always deployed in their entirety, even if no changes have been made to their contents.

This is obviously a big problem with composer's vendor directory that may include thousands of files.

To reproduce:

  1. Create an ignore rule in .gitignore for a directory called "temporary"
  2. Add this line to your phploy.ini: include[] = 'temporary'
  3. Commit the .gitignore changes
  4. Create a new directory called "temporary"
  5. Create a file inside it
  6. Deploy
  7. Deploy again. You'll see that the file is re-uploaded despite there having been no changes made
@janjaromirhorak
Copy link

janjaromirhorak commented Jan 30, 2021

I have experienced this issue as well in a configuration with a vendor/ directory, that is ignored by git, but included using include[] = 'vendor/'. Running 'sync' and then 'deploy' deploys the vendor folder.

(In case of the standard composer setup I am using, vendor can be configured as a conditional include: include[] = 'vendor:composer.lock'. The downside is that the whole vendor directory is reuploaded regardless of the real diff between the local and remote vendor folder.)

@danielzzz
Copy link

I guess this is because included directories are not controlled in git and it's hard to estimate if they have changed or not between deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants