Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include tests #17

Open
4 of 6 tasks
balthasars opened this issue Mar 23, 2021 · 0 comments
Open
4 of 6 tasks

Include tests #17

balthasars opened this issue Mar 23, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@balthasars
Copy link
Owner

balthasars commented Mar 23, 2021 •
edited
Loading

  • read test chapter in R Packages book, see https://r-pkgs.org/tests.html
  • define tests
    • use filings by multiple asset managers
    • use filings by single asset manager
    • data from different years and most current one
    • define test assuring all filings are available upon unnesting
    • for helpers
      • master_indices <- purrr::map_df(2020, tidysec:::get_master_indices_for_single_year)

Maybe: check out better structure for tests
@balthasars balthasars added the enhancement New feature or request label Mar 23, 2021
balthasars added a commit that referenced this issue Apr 6, 2021
@balthasars
use unit tests #17
675ac7c
balthasars added a commit that referenced this issue Apr 6, 2021
@balthasars
additional test for newer data #17
5fa5cb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@balthasars