Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Dynamically switching pullRight when closed leads to sidebar visually moving over #172

Open
pareis opened this issue Sep 22, 2018 · 1 comment

Comments

@pareis
Copy link

pareis commented Sep 22, 2018

Environment

  • Chrome lastest on Mac OS X 10.13

Steps to reproduce

  1. Open the demo http://balloob.github.io/react-sidebar/example/
  2. Click open to open the sidebar
  3. Click on the overlay to close it
  4. Click on pullRight checkbox

Expected Outcome

There is no visible effect resulting from the sidebar moving over

Actual Outcome

The sidebar will appear on the right and transition to close immediately

Comments

  • As a result of this, it is impossible to switch the pullRight flag dynamically, because you will always see that it happens even though it immediately closes
  • It is not required to do steps 1-3 of the above, because just toggling pullRight will result in visibility of the sidebar moving over
@markusenglund
Copy link
Collaborator

I'll gladly accept a PR for this if you want to commit the effort to do it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants