Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are values normalized before "before" lifecycle callbacks #5625

Open
Alessy opened this issue May 16, 2019 · 6 comments
Open

Why are values normalized before "before" lifecycle callbacks #5625

Alessy opened this issue May 16, 2019 · 6 comments
Labels
helpful info or workaround mysql Issue only occurs when using MySQL orm Related to models, datastores, orm config, Waterline, sails-hook-orm, etc. question resolved v1.x

Comments

@Alessy
Copy link

Alessy commented May 16, 2019

Node version: 8.16.0
Sails version (sails): 1.2.1
ORM hook version (sails-hook-orm): 2.1.1
DB adapter & version (sails-mysql): 1.0.1


When creating a record in the database, following code executes

Model.create(initialValues);

Let's say that initialValues object has some additional attributes that Model don't have.
initialValues object is normalized (additional attributes are omitted) before lifecycle callback beforeCreate is called.

In sails v0.12 initialValues object was normalized after beforeCreate lifecycle callback, but in versions after 1.0 this has changed. Why? Now I have problems upgrading my application.

If I set schema: false in config/models.js initialValues object is not normalized. But then I have to omit additional attributes by myself otherwise, the error ER_BAD_FIELD_ERROR happens.
If I want to do this (omit additional attributes) in beforeCreate in config/models.js I can't. because I don't know which specific model is being created, so I don't know which attributes to omit.

Help is needed

@sailsbot
Copy link

@Alessy Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@RavirajKakadeGit
Copy link

Hi Alessy,

We have facing same issue while upgrading sails 0.12 to 1.0
You need to add extra settings:

module.exports.models.attributes.id = { type: 'string', autoIncrement: true } and

  beforeCreate: function (modelObj, next) {
    modelObj.id = uuidv4(); // generate unique id
    next();
  } 

and remove id field from model attribute.

Thanks

@johnabrams7 johnabrams7 added mysql Issue only occurs when using MySQL orm Related to models, datastores, orm config, Waterline, sails-hook-orm, etc. v1.x question labels May 20, 2019
@johnabrams7
Copy link
Contributor

@RavirajKakadeGit Thanks for that! @Alessy Were you able to use this workaround?

You might also have greater success (and flexibility) with handling data formatting in your action instead. 👍

@Alessy
Copy link
Author

Alessy commented May 22, 2019

This workaround doesn't help me. I handle data in action now. Thanks

@johnabrams7
Copy link
Contributor

johnabrams7 commented Aug 22, 2019

@Alessy So besides the workaround, going with an action has helped instead?

@Alessy
Copy link
Author

Alessy commented Aug 27, 2019

@johnabrams7 Yes, it helped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helpful info or workaround mysql Issue only occurs when using MySQL orm Related to models, datastores, orm config, Waterline, sails-hook-orm, etc. question resolved v1.x
Development

No branches or pull requests

5 participants