Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the bank account removal reason via noc_reason instead of meta #733

Open
kyungmin opened this issue Jan 8, 2015 · 1 comment
Open

Return the bank account removal reason via noc_reason instead of meta #733

kyungmin opened this issue Jan 8, 2015 · 1 comment

Comments

@kyungmin
Copy link

kyungmin commented Jan 8, 2015

Currently bank account removal reason shows up in meta['balanced.noc_reason'] in bank accounts. This can potentially edited or removed by users. This should show up in a new field, like noc_reason.

Reference: balanced/balanced-dashboard#1619
@mjallday
Copy link
Contributor

mjallday commented Jan 9, 2015

noc_reason is going to be useless on the majority of bank accounts. why not fire an event (e.g. bank_account.invalidated) and include some meta information in that event?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyungmin @mjallday