Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

🗂 Card Interface #159

Open
ricburton opened this issue Apr 4, 2019 · 13 comments · May be fixed by #191
Open

🗂 Card Interface #159

ricburton opened this issue Apr 4, 2019 · 13 comments · May be fixed by #191
Assignees
Labels
enhancement New feature or request

Comments

@ricburton
Copy link
Member

ricburton commented Apr 4, 2019

iPhone X apps scolling

I think making each section into a card will make the UI a lot clearer.

The section headers can slide over the top of the cells so the card feels like it is compressing.

@ricburton ricburton self-assigned this Apr 4, 2019
@borwahs
Copy link
Contributor

borwahs commented Apr 4, 2019

This is 🔥!

@ricburton ricburton pinned this issue Apr 4, 2019
@ricburton ricburton added the enhancement New feature or request label Apr 4, 2019
@borwahs
Copy link
Contributor

borwahs commented Apr 8, 2019

Made a little bit of progress. Here is a playground I have that shows the Tableview with Card like sections. Still has some bugs (bottom right footer corner).

tableviewshadow.playground.zip

Screen Shot 2019-04-07 at 11 42 38 PM

@ricburton
Copy link
Member Author

Excited to check this out!

@borwahs
Copy link
Contributor

borwahs commented Apr 8, 2019

Nothing special yet. Mainly trying to get the format of the UITableView right. Curious how you feel on the dropshadows and rounding (want to make sure it is close). Couldn't match the Figmaas well as I would have liked.

I also needto get the top of the UITableView to start about 10-20 pixels down.

@borwahs
Copy link
Contributor

borwahs commented Apr 8, 2019

Here is an updated version. Getting closer.

Kapture 2019-04-08 at 10 29 02

tableviewshadow.playground-v2.zip

@borwahs
Copy link
Contributor

borwahs commented Apr 8, 2019

The key thing I am contemplating is maybe using an image for header and footer. More performant, more control, and can match the figma a lot closer. Going to try that next.

@ricburton
Copy link
Member Author

Thanks so much @borwahs. Can I help with anything?

@ricburton
Copy link
Member Author

Is this handy?

https://github.com/intuit/CardParts

@einsteinx2
Copy link
Contributor

This design will likely be very difficult using the library you wanted for expanding cells. I can try and fake it, but can't promise it will work well depending on how that library is done...

@ricburton
Copy link
Member Author

Got it. Not sure where @borwahs is with this. I am just getting back into the codebase now.

@jamierumbelow
Copy link
Collaborator

#189 is the most recent version available. Getting it tidied up and running smoothly is on my to-do list for this week.

@borwahs
Copy link
Contributor

borwahs commented May 21, 2019

@jamierumbelow & @ricburton // I have the rounded corners working and I think it looks pretty nice. Was going to work on the actual card labels to match the new design.

@jamierumbelow // maybe you could look at how we can change the tab bar and nav bar?

@borwahs
Copy link
Contributor

borwahs commented May 23, 2019

Do you guys have a good address I can use to play with the expand/collapse rows?

@jamierumbelow jamierumbelow linked a pull request Aug 27, 2019 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@jamierumbelow @einsteinx2 @ricburton @borwahs and others