Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

Detect mobile dapp browser app and provide custom button #413

Open
1 of 3 tasks
jackjdleslie opened this issue Sep 18, 2018 · 2 comments
Open
1 of 3 tasks

Detect mobile dapp browser app and provide custom button #413

jackjdleslie opened this issue Sep 18, 2018 · 2 comments

Comments

@jackjdleslie
Copy link
Contributor

What is this issue about? (select one)

  • Bug report
  • Feature request
  • Enhancement

Issue Description

If you use manager.balance.io on mobile, you either:

  1. Use Safari (or something similar) and get the option to connect to Trust Wallet, which does nothing at the moment, and use WalletConnect
  2. Use Trust Wallet, Status, Coinbase Wallet (or something similar) and get the same options, except if you press the Trust Wallet button it connects regardless of the dapp browser you use.

How about if instead of just showing the Trust Wallet button regardless, you detect which browser you are using (for this example, Safari, Trust Wallet, Status) and change the button accordingly:

1. Using Safari - Don't need to show Trust Wallet button

img_4411

2. Using Trust Wallet - detect and customise button

img_4413

3. Using Status - detect and customise button

img_4412

4. Using other (e.g Coinbase Wallet) - not officially supported so default button

img_4414

Steps to reproduce

Temporarily test it on http://boiling-caverns-82152.herokuapp.com/

@jinchung
Copy link
Contributor

@ricburton

@jackjdleslie
Copy link
Contributor Author

Addressed in #414

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants