Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color should be set by user ID, not display name #1

Open
MayeulC opened this issue Jun 1, 2021 · 3 comments
Open

Color should be set by user ID, not display name #1

MayeulC opened this issue Jun 1, 2021 · 3 comments

Comments

@MayeulC
Copy link

MayeulC commented Jun 1, 2021

Otherwise you end up with changing colors, which doesn't convey the fact that it is indeed the same user:

image

This is how nheko does it: hash user ID and distribute it on a color wheel, ensure the contrast is good enough.

Element uses a simpler approach with a LUT and 8 colors, configurable with a theme.

@bakkot
Copy link
Owner

bakkot commented Jun 1, 2021

Hm, I'm undecided about this. I've also seen someone log in using multiple matrix accounts on different homeservers, but set their display name to the same thing each time; in that case the current behavior is correct.

In practice I doubt it'll come up much; people don't tend to change either very often, in my experience.

@MayeulC
Copy link
Author

MayeulC commented Jun 1, 2021

It really depends which room you are in, some use that as a status message, since you can have per-room nicks (/myroomnick in Element).

As you prefer, that's just how most Matrix clients handle it, and I was surprised while perusing the log. That's all :)

@bakkot
Copy link
Owner

bakkot commented Jun 1, 2021

I suppose it makes sense to match prevailing convention among other matrix clients. I'll put it on my backburner to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants