fix: set the test env differently

bahmutov · May 6, 2024 · e5c7e14 · e5c7e14
1 parent bd31b44
commit e5c7e14
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 2 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -23,5 +23,5 @@
   "editor.formatOnPaste": false,
   "editor.formatOnType": false,
   "editor.formatOnSave": true,
-  "workbench.colorTheme": "FireFly Pro Bright"
+  "workbench.colorTheme": "Sublime Material Theme - Light"
 }
diff --git a/dist/index.js b/dist/index.js
@@ -338,6 +338,8 @@ const npmInstallAction = async () => {
     // From: https://github.com/actions/cache/blob/a2ed59d39b352305bdd2f628719a53b2cc4f9613/src/saveImpl.ts#L96
     if (process.env.NODE_ENV !== 'test') {
       process.exit(0)
+    } else {
+      core.debug('skip process.exit(0) in test mode')
     }
   } catch (err) {
     console.error(err)

diff --git a/index.js b/index.js
@@ -331,6 +331,8 @@ const npmInstallAction = async () => {
     // From: https://github.com/actions/cache/blob/a2ed59d39b352305bdd2f628719a53b2cc4f9613/src/saveImpl.ts#L96
     if (process.env.NODE_ENV !== 'test') {
       process.exit(0)
+    } else {
+      core.debug('skip process.exit(0) in test mode')
     }
   } catch (err) {
     console.error(err)

diff --git a/package.json b/package.json
@@ -6,7 +6,7 @@
   "scripts": {
     "format": "prettier --write './**/*'",
     "format:check": "prettier --check './**/*'",
-    "test": "NODE_ENV=test npm run unit",
+    "test": "npm run unit",
     "unit": "mocha test/helper 'test/*spec.js'",
     "pretest": "npm run build",
     "build": "ncc build -o dist index.js",

diff --git a/test/helper.js b/test/helper.js
@@ -1,3 +1,6 @@
+// https://github.com/bahmutov/npm-install/pull/228
+process.env.NODE_ENV = 'test'
+
 // following guide
 // https://glebbahmutov.com/blog/mocha-and-sinon/
 const chai = require('chai')