Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few minor bugs to fix #195

Open
buzz13 opened this issue Nov 20, 2024 · 2 comments
Open

Few minor bugs to fix #195

buzz13 opened this issue Nov 20, 2024 · 2 comments

Comments

@buzz13
Copy link

buzz13 commented Nov 20, 2024

Describe the bug

Paging on homepage is not working as expected. Next button goes over total pages.

Expected behavior

It is pretty clear.

Additional context

Nothig so far.

Beyond all

If you're interested I did some changes to your code and visual style. Instead bootstrap I have used bulma with multi theme approach.
Changed paging (added some additional code), moved framework list into the json file instead to be hardcoded, added block to properly show Readme.md file and that's pretty much all I did. I am not really a developer but have some knowledge.

You can check it how it looks here

@Regenhardt
Copy link

I'm not sure what you mean about the paging, it seems fine to me. Quick example shows Humanizer.Core.da as last package on the first page, then Humanizer.Core.de as first package on the second page, which makes sense to me.

I like how you show the total pages on the bottom in your example. I don't like the theme relying on a third party though, it'd have to be a theme we can directly add to the BaGetter source.

Dark mode itself is a good idea though, we should look into that.

@buzz13
Copy link
Author

buzz13 commented Nov 28, 2024

Just installed again and seems to be fine. Not sure why it happened with 1.5 version. What I meant was, if you had more than one page, next button appeared even if it was the last page and you could navigate to oops page by pressing next button.

Understand you're not into the third party theming. Unfortunately Bulma cannot be applied directly as it is.
Glad I gave you some ideas at least. Dark theme shouldn't be a huge job to be done. Different colour scheme I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants