Improvement request: Closure

[ram108]

Is is better to use php Closure and not to write php code in strings? This issue is the only one that stops me to use soft-mocks.

As it is now:

\Badoo\SoftMocks::redefineFunction(
    'strlen',
    '$a',
    'return \\Badoo\\SoftMocks::callOriginal("strlen", [trim($a)]));'
);

Can be with closure:

\Badoo\SoftMocks::redefineFunction( 'strlen', function( $a ) {
    return \Badoo\SoftMocks::callOriginal('strlen', [trim($a)]);
}) ;

[YuriyNasretdinov]

Is is better to use php Closure and not to write php code in strings?

Most of the time yes, it is better. There may be cases when you actually don't want closures, e.g. when you want to be able to access $this inside a method. It is fairly trivial to support closures though, you can even do it youself:

<?php
class SoftMocksClosures {
  private static $closures = [];
  public static function redefineFunction($func, $params, Closure $c) {
    self::$closures[] = $c;
    $idx = count(self::$closures)-1;
    \Badoo\SoftMocks::redefineFunction($func, $params, 'return call_user_func('.__CLASS__.'::getClosure('.$idx.'), '.$params.');');
  }
  public static function getClosure($i) {
    return self::$closures[$i];
  }
}