Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography tokens, re-evaluating --css-variables #76

Open
7 tasks
badlydrawnrob opened this issue Jul 14, 2024 · 0 comments
Open
7 tasks

Typography tokens, re-evaluating --css-variables #76

badlydrawnrob opened this issue Jul 14, 2024 · 0 comments
Labels
enhancement New feature or request so-so

Comments

@badlydrawnrob
Copy link
Owner

badlydrawnrob commented Jul 14, 2024

Material uses typographic tokens
Github uses --h1-size-mobile and --h1-size
Our baseline grid is 4px and 24px line-height.
All should preview in a specimen file

It might be worth giving a little thought to the difference between device sizes (iphone, iPad), medium screens (laptops) and large screens (such as iMac), and how the typography works moving between those sizes. I'm not currently doing a whole lot of that with this repo, as it's predominantly for print, but any themes that derive their settings from this repo might want to. Print First CSS shouldn't stand in their way.

Print First CV could be viewed as a HTML document, a PDF, or printed out on paper.

Screenshot 2024-07-14 at 12 40 42 Screenshot 2024-07-14 at 12 40 07

Footnotes

  1. Some fonts have font-variation-settings and require specific styles (for instance, font-style: italic doesn't always work the way you expect). I don't want to use functions or mixins, only plain css. Perhaps these can become font tokens?

@badlydrawnrob badlydrawnrob added enhancement New feature or request so-so labels Jul 14, 2024
@badlydrawnrob badlydrawnrob changed the title Typography tokens, or re-evaluating --css-variables Typography tokens, re-evaluating --css-variables Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request so-so
Projects
None yet
Development

No branches or pull requests

1 participant