feat(phar): add phar archive to poser #65
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
reviewed
Dec 29, 2020
| @@ -28,6 +28,7 @@ public function __construct() | |||
| public function calculateWidth(string $text, int $size = self::TEXT_SIZE): float | |||
| { | |||
| $size = $this->convertToPt($size); | |||
| var_dump($this->fontPath); | |||
There was a problem hiding this comment.
I left this for this reason: box-project/box#519
docker/php-fpm/Dockerfile
Outdated
| && apt-get clean; rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* /usr/share/doc/* | ||
|
|
||
| RUN mkdir -p /home/dev/.composer \ | ||
| && chown -R 1000:1000 /home/dev/ | ||
| COPY --from=composer:2 /usr/bin/composer /usr/local/bin/composer |
There was a problem hiding this comment.
This change inside this PR is correct or we should create another PR for this?
I don't know at the moment if is necessary for phar archive.
There was a problem hiding this comment.
correct is not necessary, but I was and I updated! :)
JellyBellyDev
force-pushed
the
feat/phar-archive
branch
from
73011c9
to
19ee959
Compare
JellyBellyDev
force-pushed
the
feat/phar-archive
branch
from
19ee959
to
b8854dd
Compare
|
Any new on this? |
I had completely forgotten about this process :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add phar archive for badge generation.
closes #63