Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if deezer integration script can be improved with events #41

Open
badcel opened this issue Oct 11, 2016 · 1 comment
Open

Check if deezer integration script can be improved with events #41

badcel opened this issue Oct 11, 2016 · 1 comment

Comments

@badcel
Copy link
Owner

badcel commented Oct 11, 2016

Deezer has multiple events which could be subscribed:

Events.subscribe(Events.player.play, this._onPlayerPlay);

This would avoid polling in the integration script. If one property changes all properties could be read.

@badcel
Copy link
Owner Author

badcel commented Apr 4, 2018

Even more possible events:
Events.subscribe(Events.player.volume_changed, this.onVolumeChanged);
Events.subscribe(Events.player.repeat_changed, this.onVolumeChanged);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant