Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplication on ban voting #61

Open
d1msdale opened this issue Mar 20, 2024 · 3 comments
Open

Avoid duplication on ban voting #61

d1msdale opened this issue Mar 20, 2024 · 3 comments

Comments

@d1msdale
Copy link

Sometime when you couple of times click for voting - your vote could be duplicated. Current logic doesn't check voter for unique. I added check for this. Also I have suspicious that should change checking from _id to id in all cases, because by mongo logic '_id' and 'id' are different fields an there could be potential collision

Like a proposition should change

from push to array to update

image

@backmeupplz
Copy link
Owner

hah, that would be nice

@d1msdale
Copy link
Author

d1msdale commented Apr 7, 2024

@backmeupplz I can't create PR. I suppose because I'm not in contributor list.

@backmeupplz
Copy link
Owner

@d1msdale you should be able to :) fork and then create a PR from your fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants