Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No clone link in edit tab #9

Open
mazzech opened this issue Feb 3, 2020 · 7 comments · May be fixed by #21
Open

No clone link in edit tab #9

mazzech opened this issue Feb 3, 2020 · 7 comments · May be fixed by #21

Comments

@mazzech
Copy link

mazzech commented Feb 3, 2020

I just installed this module and do not see a clone link at the edit tab link. However, cloning works using the contextual links. I am using Backdrop 1.15 and PHP 7.2
Screenshot 2020-02-03 at 10 20 11
Screenshot 2020-02-03 at 10 20 02

@mazzech
Copy link
Author

mazzech commented Mar 6, 2020

Is there a way to hardcode the clone link in template...? Without a clone link, this module is not very useful for end users.

@mazzech
Copy link
Author

mazzech commented Mar 6, 2020

Having a link ot node/[id]/clone/confirm would help

@herbdool
Copy link
Contributor

Screenshot from 2020-05-27 23-04-46

@mazzech please compare with Basis theme and see if you see a link there. I tested on a fresh install and I see the above. Note that it is in a secondary tab not the primary. (That's a different issue - the link is there but perhaps should be moved up to the primary tabs.

@klonos
Copy link
Member

klonos commented May 29, 2020

I personally prefer the link vs the tab for a UI/UX point of view. See https://www.drupal.org/project/drupal/issues/542658

One of the biggest problems that arise from the usability testing, is that we mix actions with listing pages in the tabs of administration pages. The intentions of Mark & Leisa was to fix this, by introducing a space where actions would live.
...
Local tasks we have are rendered as tabs. Tabs are primarily a pattern for separating different 'views' on data, different information spaces. Right now, we are also putting 'actions' in there, stuff that should be buttons or links. Besides being easily overlooked, we're mixing both 'view' and 'action' operations in the local tasks and we need a mechanism that treats the two as the seperate things they are.
Tabs for tabs, links and buttons for actions. Tabs along the top, actions right there where you need them, in context of the element(s) you perform that action on (probably meaning: free to be placed where needed).

@stpaultim
Copy link
Member

Did you know about https://backdropcms.org/project/node_clone_tab ?

I like this much better than the link provided by Node Clone out of the box.

@robertgarrigos
Copy link
Member

How about including node_clone_tab code into node_clone?

@robertgarrigos
Copy link
Member

@mazzech, @stpaultim, I created a PR which adds a setting to show the link as a tab if needed. Do you want to test it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants