-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to a newer version of PHP_CodeSniffer #12
Comments
@hosef mentioned in https://forum.backdropcms.org/forum/phpcs-ruleset:
I have recently filed https://github.com/backdrop/backdrop/pull/3299/files which uses |
…ng Drupal 8.3.12 version.
I filed another PR at #18 that is similar to @hosef's approach. I think @hosef's PR at #14 is attempting to make the existing PHPCS tests compatible with PHPCS 3+, while my PR pulls in the latest coding standards from the Drupal project and replaces a lot of the current files. Both PRs still need work because the UI for Coder Review executing PHPCS tests doesn't actually work yet. Though I noticed that the Drupal module decided to remove all of the Coder Review UI entirely. It's now just a skeleton module that holds the PHPCS rules. For the next step, I think we should get the existing Backdrop Coder Review UI working with PHPCS 3+. Once that is in place, we can merge the new PHPCS rules, make a new branch of Coder Review Module, and then pull the coding standards into core PR in backdrop/backdrop-issues#3213. |
Related drupal issues:
The text was updated successfully, but these errors were encountered: