Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not setting event type by default #780

Open
egil opened this issue Jun 27, 2022 · 4 comments
Open

Not setting event type by default #780

egil opened this issue Jun 27, 2022 · 4 comments
Labels
input needed When an issue requires input or suggestions investigate This issue require further investigation before closing.

Comments

@egil
Copy link
Member

egil commented Jun 27, 2022

In the latest version of Blazor E2E tests, the KeyPressEventComponent expects the event onkeypress to be listed as keypress in KeyboardEventArgs.Type.

I think bUnit should set it automatically for the user in the EventDispatchExtensions methods, unless the user explicitly provides a different value.

Thoughts?

@egil egil added input needed When an issue requires input or suggestions investigate This issue require further investigation before closing. labels Jun 27, 2022
@linkdotnet
Copy link
Collaborator

Hmm given that it is deprecated and type seems to be always "keypress", we wouldn't bother anyone with the changed logic.

I am really neutral on this one, as I don't see any harm but also not much gain :D

@egil
Copy link
Member Author

egil commented Jun 28, 2022

Interesting. My approach is more that we should be consistent with what Blazor does "in production", even if that's not how things are supposed to be.

But I guess this is more a "figure out what Blazor does" assignment in the first place.

@linkdotnet
Copy link
Collaborator

Interesting. My approach is more that we should be consistent with what Blazor does "in production", even if that's not how things are supposed to be.

But I guess this is more a "figure out what Blazor does" assignment in the first place.

Is this something Blazor does or the Browser?

@egil
Copy link
Member Author

egil commented Jun 30, 2022

Interesting. My approach is more that we should be consistent with what Blazor does "in production", even if that's not how things are supposed to be.

But I guess this is more a "figure out what Blazor does" assignment in the first place.

Is this something Blazor does or the Browser?

Their e2e would blow up if they didn't, so I assume so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
input needed When an issue requires input or suggestions investigate This issue require further investigation before closing.
Projects
None yet
Development

No branches or pull requests

2 participants