Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional checks to prevent WsExceptionHandler from throwing undefined errors #577

Conversation

sorenjohanson
Copy link
Collaborator

closes #574

Previously, there was no check to see if newNodes actually existed, but since we're returning undefined, newNodes.length may actually throw an error.

@sorenjohanson
Copy link
Collaborator Author

sorenjohanson commented Nov 18, 2024

Additional fix: The Promise.reject() in addNodes was never returned properly, so it's propagated directly upwards to the WsExceptionHandler instead of going back to the gateway. It's now returned properly, so it also prevents execution of the reducer.

@JannikStreek
Copy link
Member

looking good, thanks!

@JannikStreek JannikStreek merged commit da8928a into b310-digital:main Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate log errors with WsExceptionsHandler undefined
2 participants