Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosing child records on copying #108

Closed
buepro opened this issue Nov 20, 2020 · 12 comments
Closed

Loosing child records on copying #108

buepro opened this issue Nov 20, 2020 · 12 comments
Assignees

Comments

@buepro
Copy link
Contributor

buepro commented Nov 20, 2020

Environment

  • TYPO3 10.4
  • container 1.2.0
  • container_elements 1.1.0

Error description

Copying container elements with child records isn't reliable. Sometimes it work and sometimes the child records are mixed up or missing. Observations:

  • When pasting container elements with child contents to a blank page child contents are available
  • When pasting container elements with child contents to a page that already has a content element child contents are not available. This is true when pasting takes place after the existing content element. When it is pasted before the existing content element the child contents are available.
  • When pasting container elements with child contents having images (FAL references) these content elements get references to additional images (e.g. when the original child element has one image the pasted pne has two images)
@ulrichmathes
Copy link

ulrichmathes commented Nov 25, 2020

Environment

  • TYPO3 10.4
  • container 1.2.0

Error description

Same here, sometimes it works, sometimes not.
No log entries.

@opi99
Copy link

opi99 commented Dec 8, 2020

Question: Do you also use content_defender ?

@buepro
Copy link
Contributor Author

buepro commented Dec 8, 2020

No, content_defender isn't used.

@opi99
Copy link

opi99 commented Dec 8, 2020

Thanks for feedback, I'm debugging such an issue at the moment on a project with content_defender

@ulrichmathes
Copy link

Question: Do you also use content_defender ?

Yes we are.

@achimfritz
Copy link
Contributor

thanks for reporting and example,
Observation 2: got it, pid of children is not updated to pid of container, when copy container after an element on other page. I will care.

@achimfritz achimfritz self-assigned this Dec 11, 2020
@opi99
Copy link

opi99 commented Dec 11, 2020

@achimfritz I'm also debugging in this area at the moment I found this one (it isn't directly this issue but seams to be related) IchHabRecht/content_defender#76 and and added a pull request there.
But this issue persists afterwards but it changes from "only happens by pasting after an element" to "happens everytime when an element is pasted from another page" so it looks like an issue while calculating the parent on the new page.

@achimfritz
Copy link
Contributor

Observation 2 is fixed by PR

Can anybody give an exact example how the error in "Observation 3" occures? (for me all seems work fine)

@opi99
Copy link

opi99 commented Dec 14, 2020

@achimfritz Thanks, this works for me.

@opi99
Copy link

opi99 commented Dec 14, 2020

Till yet, I also didn't get "Observation 3" and I'm hardly testing.

@buepro
Copy link
Contributor Author

buepro commented Dec 14, 2020

The issue could be reproduced by pasting a container element with children on a page where there are already container elements. By pasting it below the already available content elements the child element gets lost or isn't shown (observation 2). When adding a new child element just the newly added child element is shown. Copying and pasting this container to a new page where no content elements are present, the newly inserted container element shows two children: The one originally copied and not shown on the first pasted container element and the one added to the first pasted container element.

It looks like with fixing Observation 2 the issue gets resolved.

@achimfritz
Copy link
Contributor

so i close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants