Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After installing Kodi crashes immediately after it finished loading due to Embuary.helper and Embuary.helper tries to access private folders in /home #90

Closed
mYnDstrEAm opened this issue Oct 12, 2022 · 16 comments

Comments

@mYnDstrEAm
Copy link

mYnDstrEAm commented Oct 12, 2022

On Debian11 with Kodi 19.1 I installed the skin after installing the kodinerds repo. It asked me to also install Embuary Helper or something similar. Once it was installed I added a new option to the left sidebar and moved a few items there (which worked great and was useful for this). It then crashed (I don't think I quit it).

I then tried launching Kodi again but as soon as it finishes loading it crashes. With finishing loading I mean that it correctly displays Kodi and the Favorites page which I had opened before it quit and I can even switch pages (Movies, Series, ...) for almost one second. I'm using Kodi with firejail for security sandboxing which worked well with Kodi (command firejail kodi).

Here are the warnings in kodi.log after load skin from: /home/username/.kodi/addons/skin.estuary.modv2/ (version: 3.4.2+matrix.5):

...
WARNING <general>: CApplication::Initialize - startup.xml taints init process
WARNING <general>: JSONRPC: Could not parse type "Setting.Details.SettingList"
...
WARNING <general>: Skin has invalid include: skinshortcuts-template-PersonalWidgetList
WARNING <general>: Skin has invalid include: skinshortcuts-template-PersonalWidgetPanel
WARNING <general>: Skin has invalid include: skinshortcuts-template-PersonalWidgetVariable
...

In the console it has this output:

...
Child process initialized in x ms
/usr/bin/kodi: 1: ulimit: error setting limit (Operation not permitted)
kodi: ulimit is unsupported by this shell
failed to open zone.tab
libva info: VA-API version 1.10.0
libva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_10
libva info: va_openDriver() returns 0
sh: 1: nmblookup: Permission denied
context.c:56: warning: mpd_setminalloc: ignoring request to set MPD_MINALLOC a second time

context.c:56: warning: mpd_setminalloc: ignoring request to set MPD_MINALLOC a second time

context.c:56: warning: mpd_setminalloc: ignoring request to set MPD_MINALLOC a second time

context.c:56: warning: mpd_setminalloc: ignoring request to set MPD_MINALLOC a second time

Segmentation fault
find: '/home/username/.folder': Permission denied
find: '/home/username/.folder2': Permission denied
find: '/home/username/.folder3': Permission denied
...
cat: /proc/sys/kernel/core_pattern: Permission denied
cat: /proc/sys/kernel/core_pattern: Permission denied
dirname: missing operand
Try 'dirname --help' for more information.
Crash report available at /home/username/kodi_crashlog-20221012_time.log

Parent is shutting down, bye...

I think the outputs until nmblookup are normal and I had them before, I think had these mpd_setminalloc warnings before too but iirc not always and not four. I don't think I had the remaining errors. It shouldn't try to access these folders, it's a reason why I'm using sandboxing.

@b-jesch
Copy link
Owner

b-jesch commented Oct 12, 2022

Warnings are not errors.

WARNING : Skin has invalid include: skinshortcuts-template-PersonalWidgetList
WARNING : Skin has invalid include: skinshortcuts-template-PersonalWidgetPanel
WARNING : Skin has invalid include: skinshortcuts-template-PersonalWidgetVariable

simply means that you don't have any self created widgets in use and therefore the templates of skinshortcuts will not used. You can ignore that.

The reason for crashing kodi (not the skin) ist the segmentation fault. Look into the crash report.

@mYnDstrEAm
Copy link
Author

mYnDstrEAm commented Oct 12, 2022

There are no errors after the load skin from entry there either, only those same 5 warnings. There are errors only before it loads the skin:

ERROR <general>: DBus error: org.freedesktop.DBus.Error.InvalidArgs - No such property “OnLowBattery”
ERROR <general>: DBus error: org.freedesktop.DBus.Error.InvalidArgs - No such property “CanSuspend”
ERROR <general>: DBus error: org.freedesktop.DBus.Error.InvalidArgs - No such property “CanHibernate”

I think these three errors are normal. Haven't enabled debug mode.

Also even it does work the skin should not try to access folders in the /home partition, Kodi didn't do that before installing the skin.

I think I press yes to a second prompt of installing an Embuary addon and it crashed afterwards, maybe it has something to do with that. Is there maybe a way to edit a config file to disable the newly installed addons and see if Kodi works then so one can at least find out the addon that's causing it. Otherwise, no idea why this segmentation fault occurs.

The last few log entries are:

WARNING <general>: Skin has invalid include: skinshortcuts-template-PersonalWidgetVariable
INFO <general>: initializing python engine.
INFO <general>: Skipped 2 duplicate messages..
INFO <general>: [script.module.pvr.artwork] Initialized
INFO <general>: PVR Artwork module wrapper started
INFO <general>: [ script.embuary.info ] Refreshing next airing database
INFO <general>: [ script.embuary.info ] Finished next airing database refreshing
INFO <general>: [ script.embuary.helper ] Service: Started
INFO <general>: [ script.embuary.helper ] Service: Player monitor started

@C4Wiz
Copy link
Contributor

C4Wiz commented Oct 12, 2022 via email

@mYnDstrEAm
Copy link
Author

That's not really helpful. They are only in one specific folder in the home dir and Kodi never tried to access these folders previously. Please keep the message as short as possible. I'm first trying to find out the cause of the crashing and fix it and then worry about it trying to access these folders.

@C4Wiz
Copy link
Contributor

C4Wiz commented Oct 12, 2022 via email

@mYnDstrEAm
Copy link
Author

mYnDstrEAm commented Oct 12, 2022

I don't want to undo all the many settings I have done before. I asked Is there maybe a way to edit a config file to disable the newly installed addons and see if Kodi works then so one can at least find out the addon that's causing it which is what I would intend to do next.

Edit: did that now simply by moving the folders script.embuary.info and script.embuary.helper out of /home/username/.kodi/addons/. No crash now and it shows a prompt to install that Embuary addon again. I'll try reinstalling it.

Edit 2: without installing the Embuary addon it shows the output below in the console (compare with the output above). Everything seems to work without that estuary addon, is it really needed? What is it used for? (But if I don't install it I need a way to make the prompt not always show up.)

libva info: va_openDriver() returns 0
sh: 1: nmblookup: Permission denied
context.c:56: warning: mpd_setminalloc: ignoring request to set MPD_MINALLOC a second time

context.c:56: warning: mpd_setminalloc: ignoring request to set MPD_MINALLOC a second time

sh: 1: nmblookup: Permission denied

Edit 3: if I press yes to install that Embuary addon the exact same thing as before occurs. It tries to access all these files which it shouldn't and Kodi crashes. It's the Estuary helper addon, not the info addon (can't press yes to the second prompt to install that too as it crashes before I can). Seems like I need to uninstall the skin.

@mYnDstrEAm mYnDstrEAm changed the title After installing Kodi crashes immediately after it finished loading After installing Kodi crashes immediately after it finished loading due to Embuary.helper and Embuary.helper tries to access private folders in /home Oct 12, 2022
@C4Wiz
Copy link
Contributor

C4Wiz commented Oct 12, 2022 via email

@b-jesch
Copy link
Owner

b-jesch commented Oct 13, 2022

Kodi install and access all additional addons (even skin and helpers) in $HOME/.kodi/ . That's the normal behaviour. Only a fresh installation without any addons resides in /usr/share/kodi.

Note that Team kodi offers no support for an installation of Kodi from Debian. See installation notes here: https://kodi.wiki/view/HOW-TO:Install_Kodi_for_Linux#Installing_Kodi_on_Ubuntu-based_distributions_with_Team_Kodi_PPA

As this issue does not concern the skin, I'm closing it. Please discuss in the appropiate forums of kodi.tv

Regards

@b-jesch b-jesch closed this as completed Oct 13, 2022
@mYnDstrEAm
Copy link
Author

Create a backup, then reset. Then install only the skin in question, if it doesn’t crash then it’s something else you installed. Then it’s a issue for the kodi forum!

Already could restore it, as I wrote, by removing those two folders and then uninstalling the skin. So there's no need to restore a backup and reset all the many changes to Kodi settings that may have been done in the meantime. I only installed the skin in question as wrote as well. The skin asks me to install the Embuary addon. It's also an issue for the Embuary helper GitHub repo, not the forum, because that's what causing the crash.

Kodi install and access all additional addons (even skin and helpers) in $HOME/.kodi/ . That's the normal behaviour. Only a fresh installation without any addons resides in /usr/share/kodi.

Sure but how is this relevant to anything I wrote?

How does this address the crash and that it tries to access all the hidden folders in /home/username/?

Kodi 19.1 is now in the Debian repos, I don't know how well supported that combination is with Kodi's core developers but I don't think it matters here.

As this issue does not concern the skin, I'm closing it. Please discuss in the appropiate forums of kodi.tv

Wouldn't consider this issue closed but the problem is caused by the Embuary helper addon. I will file a bug report there (at its GitHub repo). If a dependency causes crashes (and tries to access personal files without a need for this like malware does), then I think it's also a problem of the software that uses the dependency, one alternative could be to not use that dependency or to switch it out for another one.

@mYnDstrEAm
Copy link
Author

mYnDstrEAm commented Oct 13, 2022

Issue is now here: sualfred/script.embuary.helper#67
Edit: and post in forum here.

@b-jesch
Copy link
Owner

b-jesch commented Oct 13, 2022

Sure but how is this relevant to anything I wrote?

Here:

Also even it does work the skin should not try to access folders in the /home partition, Kodi didn't do that before installing the skin.

The Embuary Helper is essential for the skin. Without the helper you lost a lot of functionality.

@b-jesch
Copy link
Owner

b-jesch commented Oct 13, 2022

And again: $HOME/.kodi is not a private folder, this is a hidden folder and contains almost all installed addons of the current installation, the config of all addons + the config of Kodi itself (.kodi/userdata), the Video/Audio databases (.kodi/userdata/Databases) and more...

@mYnDstrEAm
Copy link
Author

mYnDstrEAm commented Oct 13, 2022

I think we misunderstood each other as I still mostly don't see how it's related. I know those things about the $HOME/.kodi folder, iirc that is the only folder in home/username that I allow Kodi to access, but the addon tries to access all the hidden folders in that directory.

If the Embuary Helper is essential for the skin, that would be a reason for keeping this issue open as a crashes due to it also affect the skin as it can't get replaced and needs to get (and remain) installed when installing the skin. Closing is fine too if you/people keep track of the new issue I created at the other repo but if people get this same crash or wonder about it accessing private files (for example private encryption keys), then keeping it open here would be useful...especially as it doesn't look like the other repo gets currently maintained much (source code isn't even on GitHub and latest release is from April 2021).

@b-jesch
Copy link
Owner

b-jesch commented Oct 13, 2022

For now You are the first with such an issue. Note, Kodi 19.1 is quite old - the actual version is 19.5. Nobody runs Kodi in a sandbox and there is no official support for a Debian-Kodi from Team Kodi. On other side there are reported issues with some Python versions used in Debian which caused Kodi to crash. Not a skin problem.

Google for "Debian kodi python crash" (without ").

@mYnDstrEAm
Copy link
Author

Just to add: there are many who run Kodi with firejail, it has its own profile which ships with firejail. Without firejail I wouldn't have noticed the issue about it trying to access these folders and it may also be involved in what's causing the crash. Didn't have Kodi python crashes so far. Not a problem of the skin, but probably of one of its dependencies.

@b-jesch
Copy link
Owner

b-jesch commented Oct 13, 2022

Not a problem of the skin, but probably of one of its dependencies.

Yes, but this is not on my site. You have done the right way to inform the maintainer of the helper addon. Meanwhile we have to wait for an answer...

You can remove the dependency from the helper addon in the addon.xml of the skin, but don't wonder if the skin has only limited functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants