Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Upgrade yarn + typescript packages on Jenkins to address missing whitespace error #325

Open
CloudNiner opened this issue Nov 28, 2017 · 2 comments

Comments

@CloudNiner
Copy link

Any line in a jsdoc comment containing @param like:

* @param indicatorName - Name of indicator, used for SVG selector

such as the ones in image-export.service.ts throws the error:

ERROR: /opt/app/src/app/services/image-export.service.ts[23, 15]: missing whitespace

but only in the Jenkins environment, which has an outdated version (0.24.4) of yarn.

In #324 we temporarily addressed this by disabling the tslint whitespace.check-separator rule. A more thorough fix would be to ensure that yarn + typescript + tslint +tsutils are all up to date and then re-add the check-whitespace rule.

See palantir/tslint#3251 for a full writeup of the original problem.

@CloudNiner CloudNiner changed the title Upgrade yarn + typescript packages to address missing whitespace error Upgrade yarn + typescript packages on Jenkins to address missing whitespace error Nov 29, 2017
@CloudNiner
Copy link
Author

In addition, @maurizi left this comment in slack:

builds aren't (yet) isolated from each other

which may be appropriate to address as well to avoid transient errors when builds change the installed package versions.

@maurizi
Copy link
Contributor

maurizi commented Nov 29, 2017

builds aren't (yet) isolated from each other

I think the changes in #321 are meant to address this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants