Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Remove forRoot calls from ChartsModule #26

Open
CloudNiner opened this issue Dec 18, 2017 · 0 comments
Open

Remove forRoot calls from ChartsModule #26

CloudNiner opened this issue Dec 18, 2017 · 0 comments

Comments

@CloudNiner
Copy link
Contributor

For the ngx-bootstrap modules.

It's clear in the Angular documentation that forRoot() calls should only be made from the root AppModule. ChartsModule is not one of those so it shouldn't have the forRoot calls.

However, it's unclear how we should handle this here. If we remove the forRoot calls, then we break the abstraction of our library and require users to both include ngx-bootstrap as a dependency in the application that uses this lib and perform specific setup steps for this library, namely adding ngx-bootstrap module imports with the forRoot calls in their AppModule. If we don't remove the forRoot calls, we may have subtle breakage occur down the road. It may be worth investigating if theres a way to not break library abstractions and still call the appropriate ngx-bootstrap forRoot methods in the correct place.

In progress branch that implements the simple "remove the forRoot calls and let the parent handle it" case: https://github.com/azavea/climate-change-components/tree/feature/awf/remove-forroot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants