You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
wmi_get_event_data is part of the GUID-based WMI interface (deprecated in torvalds/linux@d54bd4b). This function was removed in torvalds/linux@79a56f4, allegedly because its improper usage had potential to mess up ACPI firmware on some machines.
Additionally, the signature of wmi_install_notify_handler's callback changed from void (*)(u32, void *) to void (*)(union acpi_object *, void *) in torvalds/linux@e04e2b7, to replace the removed functionality. The in-tree copy of huawei-wmi was also patched accordingly, and this patch can be carried forward into this version.
Build failure log
CC [M] /build/source/huawei-wmi.o
/build/source/huawei-wmi.c: In function 'huawei_wmi_input_notify':
/build/source/huawei-wmi.c:1480:18: error: implicit declaration of function 'wmi_get_event_data'; did you mean 'acpi_get_event_status'? [-Werror=implicit-function-declaration]
1480 | status = wmi_get_event_data(value, &response);
| ^~~~~~~~~~~~~~~~~~
| acpi_get_event_status
/build/source/huawei-wmi.c: In function 'huawei_wmi_input_setup':
/build/source/huawei-wmi.c:1510:50: error: passing argument 2 of 'wmi_install_notify_handler' from incompatible pointer type [-Werror=incompatible-pointer-types]
1510 | wmi_install_notify_handler(guid, huawei_wmi_input_notify,
| ^~~~~~~~~~~~~~~~~~~~~~~
| |
| void (*)(u32, void *) {aka void (*)(unsigned int, void *)}
In file included from /build/source/huawei-wmi.c:8:
/nix/store/hs64hbfp8c68syszdy8i3zjlmi9r3a76-linux-6.12-dev/lib/modules/6.12.0/source/include/linux/acpi.h:404:60: note: expected 'wmi_notify_handler' {aka 'void (*)(union acpi_object *, void *)'} but argument is of type 'void (*)(u32, void *)' {aka 'void (*)(unsigned int, void *)'}
404 | wmi_notify_handler handler, void *data);
| ~~~~~~~~~~~~~~~~~~~^~~~~~~
cc1: some warnings being treated as errors
The text was updated successfully, but these errors were encountered:
wmi_get_event_data
is part of the GUID-based WMI interface (deprecated in torvalds/linux@d54bd4b). This function was removed in torvalds/linux@79a56f4, allegedly because its improper usage had potential to mess up ACPI firmware on some machines.Additionally, the signature of
wmi_install_notify_handler
's callback changed fromvoid (*)(u32, void *)
tovoid (*)(union acpi_object *, void *)
in torvalds/linux@e04e2b7, to replace the removed functionality. The in-tree copy of huawei-wmi was also patched accordingly, and this patch can be carried forward into this version.Build failure log
The text was updated successfully, but these errors were encountered: