Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The call method in executor should handle system contracts as exec method does. #1592

Closed
yangby-cryptape opened this issue Nov 23, 2023 · 2 comments · Fixed by #1597
Closed
Assignees
Labels
enhancement New feature or request

Comments

@yangby-cryptape
Copy link
Collaborator

Description

Current status

Issues introduced by the above Design

When call system contracts —— for example, call eth_estimateGas —— it may lead to unexpected results.

Also, unexpected results may be occurred when replay system contracts (ref: #1234 tried).

Proposals

  • Do same operations for both exec and call.

  • Or, just reject system contracts directly in the call method.

@Flouse Flouse added the agenda label Nov 24, 2023
@yangby-cryptape yangby-cryptape self-assigned this Nov 24, 2023
@yangby-cryptape yangby-cryptape added the d:confirmation Discussion required to confirm whether it's a bug label Nov 24, 2023
@Flouse
Copy link
Contributor

Flouse commented Nov 27, 2023

confirmed solution

  • just reject system contracts directly in the call method

@Flouse Flouse added enhancement New feature or request and removed agenda d:confirmation Discussion required to confirm whether it's a bug labels Nov 27, 2023
@yangby-cryptape
Copy link
Collaborator Author

I found that #1597 will resolve this issue.

p.s. This comment is created via GitHub CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants