Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library is currently broken and not usable. #24

Open
anzorbalkar opened this issue Feb 6, 2021 · 0 comments
Open

Library is currently broken and not usable. #24

anzorbalkar opened this issue Feb 6, 2021 · 0 comments

Comments

@anzorbalkar
Copy link

Using a Zebra TC21, on the playground website, it works perfectly with default options.

However using this version (via npm install) with identical configuration, it does not.

Weirdly observed that if you call onScan.simulate(... first, subsequent scanning will work using this library will work.

This is super suspicious because why would a debug method need to be called in order for the non-debug code to work?!

Looking at the code, it seems onScan.simulate calls this._reinitialize.

Otherwise, this._reinitialize is never called.

Looking at commit history, this method used to be called in the good ol attachTo method.

However in the commit titled 'many improvements', this call was straight up deleted, and it seems was not eventually called in some other way.

Should this call simply be added back? Or was the intention of that commit for this._reinitialize to be eventually called in some other way..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant