Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings when deployed gateway, voting verifier, and multisig prover contracts #933

Open
Olanetsoft opened this issue Apr 18, 2024 · 2 comments
Assignees
Labels

Comments

@Olanetsoft
Copy link
Contributor

... from devnet-amplifier.json using the Cosmwasm rust-optimizer.

warning: unused import: `axelar_wasm_std::VerificationStatus`
 --> contracts/aggregate-verifier/src/msg.rs:1:5
  |
1 | use axelar_wasm_std::VerificationStatus;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: `aggregate-verifier` (lib) generated 1 warning (run `cargo fix --lib -p aggregate-verifier` to apply 1 suggestion)
    Finished release [optimized] target(s) in 5m 47s
warning: unused import: `multisig::worker_set::WorkerSet`
 --> contracts/monitoring/src/msg.rs:4:5
  |
4 | use multisig::worker_set::WorkerSet;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
  
  warning: unused import: `axelar_wasm_std::VerificationStatus`
 --> contracts/aggregate-verifier/src/msg.rs:1:5
  |
1 | use axelar_wasm_std::VerificationStatus;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: `aggregate-verifier` (lib) generated 1 warning (run `cargo fix --lib -p aggregate-verifier` to apply 1 suggestion)
@cgorenflo
Copy link
Contributor

unfortunately, the rust compiler isn't aware that these imports are actually needed for an attribute macro in those files, it's a false positive. These warnings can be ignored, we are thinking about the best way to get rid of them.

@ffe9f8
Copy link
Contributor

ffe9f8 commented Aug 6, 2024

Add to error messages doc

@ffe9f8 ffe9f8 assigned ffe9f8 and unassigned haiyizxx and cgorenflo Aug 6, 2024
@ffe9f8 ffe9f8 added the P1 label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants