Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Checking a video that has been removed from youtube causes the video's accessory files to be deleted #676

Open
tsk-2222 opened this issue Dec 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@tsk-2222
Copy link

tsk-2222 commented Dec 26, 2024

Win10
Tartube V2.5.062

When you run re-check on a video, tartube deletes the video's accessory files before it actually has new files to replace them with.
If the youtube video is currently unavailable, this causes loss of those files.

PS. Love the Santa icon. Nice touch!

@tsk-2222 tsk-2222 added the bug Something isn't working label Dec 26, 2024
@axcore
Copy link
Owner

axcore commented Dec 27, 2024

I can't see a way around it; if we don't delete the files, then yt-dlp will not download replacements. Therefore the re-check function shouldn't be used to test whether a video is still available, but only when you actually want to replace its accessory files.

@tsk-2222
Copy link
Author

tsk-2222 commented Dec 28, 2024

Would it be feasible to :

temporarily rename the files
run yt-dlp
delete or revert the files depending on yt-dlp's exit code and/or the existence of the new files

From this yt-dlp github comment: yt-dlp/yt-dlp#4262 (comment)
0 = Everything is successful
100 = yt-dlp must restart for update to complete
101 = Download cancelled by --max-downloads etc
2 = Error in user-provided options
1 = Any other error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants