Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use a href="#" for buttons #97

Open
sventschui opened this issue Dec 11, 2016 · 0 comments
Open

Do not use a href="#" for buttons #97

sventschui opened this issue Dec 11, 2016 · 0 comments

Comments

@sventschui
Copy link
Contributor

It is discouraged to use <a href="#" ... for buttons. Use real buttons (<button>) for accessibility reasons.

Using real buttons will break some stuff (e.g. burger) because buttons have a background and border by default.

.header-burger {
  border: none;
  background: transparent;
}

.header-meta-menu-link {
  border: none;
  background: transparent;
}

.mask {
  border: None;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant