Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should of non-standard / pre-standard features be managed? #171

Open
bifurcation opened this issue Jun 25, 2024 · 1 comment
Open

How should of non-standard / pre-standard features be managed? #171

bifurcation opened this issue Jun 25, 2024 · 1 comment

Comments

@bifurcation
Copy link
Contributor

Problem:

As folks use this library more, they will run into use cases that are not covered by the base MLS functionality. For example, #170 describes a use case for a new Replace proposal. While these features are not standard, we should somehow isolate them from the main code base, and probably allow consumers to opt out of them.

Solution:

There are a few tools available here:

  • Isolating new features in submodules
  • Creating an extensions sub-module that captures behavior that goes beyond RFC 9420
  • Using feature flags to enable / disable extension features

It seems to me that feature flags are a good option regardless of where the code goes, so that consumers can manage whether extension features are enabled. I don't have a very strong feeling about where the code should go. Given that some extension functionality might need visibility into protocol internals (as #170) does, it might be simplest to have it in place, though judicious use of pub(crate) could make it feasible to have it in a sub-module.

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

  • RFC links: N/A
  • Related Issues: Add a Replace proposal #170 is an example of extension functionality
  • Testing: N/A, this is just a process / code structure decision

Out of scope:

N/A

@tomleavy
Copy link
Contributor

Hey @bifurcation . I'm definitely a fan of the feature flag approach. There can be an experimental feature that enables individual features for each extension we want to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants