Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: option to use preconfigured vpc versus creating a new one #853

Open
naeem-gitonga opened this issue Jun 8, 2023 · 5 comments

Comments

@naeem-gitonga
Copy link

naeem-gitonga commented Jun 8, 2023

Hi:
I am working in an environment that requires me to avoid creating new VPCs. I would like to request a feature for allowing the user of the construct to pass the construct their own VPC for use with the Clamscan construct's resources. This would also allow the user to specify the subnets to use with the VPC. In response to this request, I have made a PR.

Thank you!

@dontirun
Copy link
Contributor

dontirun commented Jun 9, 2023

Thanks for the feature request and PR! There are a few other changes that would need to be made in order for this to work. Those changes would mutate the existing VPC configuration so I have some concerns about implementing them.

@naeem-gitonga
Copy link
Author

Thank you for responding! I will do more digging and connect soon.

@villelahdenvuo
Copy link

VPC created by this construct does not follow AWS security best practices:
Screenshot 2023-09-01 at 17 28 00

@dontirun
Copy link
Contributor

dontirun commented Sep 1, 2023

VPC created by this construct does not follow AWS security best practices:
Screenshot 2023-09-01 at 17 28 00

I'm most cases I would agree that's a problem, but in this case the VPC doesn't have any mechanism to allow for outbound traffic besides the S3 gateway endpoint

@villelahdenvuo
Copy link

Looks like there is a workaround for this using the CDK feature flags: this.node.setContext(EC2_RESTRICT_DEFAULT_SECURITY_GROUP, true);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants