chore: Update to Gradle 8 #1829
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
Nov 21, 2024
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip | |||
There was a problem hiding this comment.
Autogenerated change
jbelkins
commented
Nov 21, 2024
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env sh | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
This whole file is an autogenerated change
jbelkins
commented
Nov 21, 2024
| @@ -29,6 +29,9 @@ if "%DIRNAME%" == "" set DIRNAME=. | |||
| set APP_BASE_NAME=%~n0 | |||
| set APP_HOME=%DIRNAME% | |||
There was a problem hiding this comment.
Whole file is autogenerated
jbelkins
commented
Nov 21, 2024
| args = lintPaths | ||
| } | ||
|
|
||
| tasks.register<JavaExec>("ktlintFormat") { | ||
| description = "Auto fix Kotlin code style violations" | ||
| group = "formatting" | ||
| classpath = configurations.getByName("ktlint") | ||
| main = "com.pinterest.ktlint.Main" | ||
| mainClass = "com.pinterest.ktlint.Main" |
There was a problem hiding this comment.
Gradle 8 changes the name of this property
jbelkins
commented
Nov 21, 2024
| html.destination = file("$buildDir/reports/jacoco") | ||
| xml.required.set(false) | ||
| csv.required.set(false) | ||
| html.outputLocation.set(file("$buildDir/reports/jacoco")) |
There was a problem hiding this comment.
Test report config updated & taken from smithy project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Gradle update instructions are here:
https://docs.gradle.org/current/userguide/upgrading_version_7.html
Updates the project from Gradle 7.2 to 8.11.1 (the latest Gradle version).
This brings us to parity with https://github.com/smithy-lang/smithy which is also on Gradle 8.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.