Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add Python isort and black linters. #684

Open
1 of 4 tasks
javydekoning opened this issue Jan 18, 2024 · 2 comments
Open
1 of 4 tasks

[Feat]: Add Python isort and black linters. #684

javydekoning opened this issue Jan 18, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@javydekoning
Copy link
Contributor

Describe the feature

To ensure code consistency we want to add 2 linters.

Use Case

Adding these linters will ease code reviews going forward.

Proposed Solution

  • Enable linter in one commit
  • Add syntax changes in the second
  • Open PR

Acknowledgements

  • I may be able to implement this feature request
@javydekoning javydekoning added the good first issue Good for newcomers label Jan 18, 2024
@alexevansigg
Copy link
Contributor

Hey Javy.. we might consider looking into ruff linter https://docs.astral.sh/ruff/

it can do i-sort linting and black formatting .. but much faster...
also can replace pylint, flake8, pep8 etc if you want to follow any rules/styles from those.

@javydekoning
Copy link
Contributor Author

I'll look into this. Seems it is included in MegaLinter: https://megalinter.io/latest/descriptors/python_ruff/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants