Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics publisher support in CRT client #806

Open
suman-ganta opened this issue Jul 15, 2024 · 5 comments
Open

Metrics publisher support in CRT client #806

suman-ganta opened this issue Jul 15, 2024 · 5 comments
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@suman-ganta
Copy link

Describe the bug

Netty based client supports specifying metrics publisher. This seem to be missing from the CRT builder. This need to be supported to publish client side metrics.

With Netty client

var client = S3AsyncClient
             .builder()
             .region(US_WEST_2)
             .overrideConfiguration(c -> c.addMetricPublisher(new MyMetricsPublisher()))
            .build()

With CRT client

var client = S3AsyncClient.crtBuilder()
            .region(US_WEST_2)
            .build()

Expected Behavior

Ability to publish client side metrics

Current Behavior

Does not have any way to publish client side metrics

Reproduction Steps

Always reproducible.

Possible Solution

No response

Additional Information/Context

No response

aws-crt-java version used

0.30.0

Java version used

18

Operating System and version

Linux

@suman-ganta suman-ganta added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 15, 2024
@jmklix
Copy link
Member

jmklix commented Jul 18, 2024

Thanks for pointing this out. This is a feature request, rather than a bug. We are looking into how complicated and what priority this feature request is.

@jmklix jmklix added feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 18, 2024
@suman-ganta
Copy link
Author

suman-ganta commented Jul 18, 2024

Thanks @jmklix for triaging. Are there workarounds or alternatives for this? How are CRT S3 client users publishing client side metrics to CloudWatch today?

@jmklix
Copy link
Member

jmklix commented Jul 31, 2024

You can try publishing your own custom metrics to CloudWatch with putMetricData.

@jmklix
Copy link
Member

jmklix commented Jul 31, 2024

P143829291

@jmklix jmklix added p3 This is a minor priority issue and removed needs-review This issue or pull request needs review from a core team member. labels Jul 31, 2024
@suman-ganta
Copy link
Author

You can try publishing your own custom metrics to CloudWatch with putMetricData.

I'm referring to publishing metrics captured by the client, which are internal to the CRT S3 client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants