Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with reference to AWS_MQTT5_COTABT_MANUAL #607

Closed
nabelekt opened this issue Apr 2, 2024 · 3 comments
Closed

Build fails with reference to AWS_MQTT5_COTABT_MANUAL #607

nabelekt opened this issue Apr 2, 2024 · 3 comments
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. guidance Question that needs advice or information.

Comments

@nabelekt
Copy link

nabelekt commented Apr 2, 2024

Describe the bug

Build fails with

In file included from /root/gateway/libraries/third_party/aws-crt-cpp/include/aws/crt/Api.h:9,
                 from /root/gateway/libraries/third_party/aws-crt-cpp/source/ImdsClient.cpp:8:
/root/gateway/libraries/third_party/aws-crt-cpp/include/aws/crt/mqtt/Mqtt5Client.h:56:26: error: ‘AWS_MQTT5_COTABT_MANUAL’ was not declared in this scope; did you mean ‘AWS_MQTT5_COTABT_LRU’?
   56 |                 Manual = AWS_MQTT5_COTABT_MANUAL,
      |                          ^~~~~~~~~~~~~~~~~~~~~~~
      |                          AWS_MQTT5_COTABT_LRU

Expected Behavior

Build not failing

Current Behavior

Build fails

Reproduction Steps

Build including Mqtt5Client

Possible Solution

I am guessing AWS_MQTT5_COTABT_MANUAL should be AWS_MQTT5_COTABT_USER

Additional Information/Context

No response

aws-crt-cpp version used

0.26.4

Compiler and version used

gcc version 13.2.0 (Ubuntu 13.2.0-4ubuntu3)

Operating System and version

Ubuntu 23.10

@nabelekt nabelekt added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 2, 2024
@nabelekt
Copy link
Author

nabelekt commented Apr 2, 2024

It looks like this issue was introduced between v0.24.7 and v0.24.8

@bretambrose
Copy link
Contributor

Your submodules are out of date with the CRT. If you update them, this should go away.

@bretambrose bretambrose removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 2, 2024
@jmklix jmklix added closing-soon This issue will automatically close in 4 days unless further comments are made. guidance Question that needs advice or information. labels Apr 2, 2024
@nabelekt
Copy link
Author

nabelekt commented Apr 2, 2024

Indeed! Apologies for the oversight.

@nabelekt nabelekt closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. guidance Question that needs advice or information.
Projects
None yet
Development

No branches or pull requests

3 participants