CMake Error at CMakeLists.txt:317 (aws_add_sanitizers): Unknown CMake command "aws_add_sanitizers"

[nunotexbsd]

Describe the bug

Configure fails:

===>  Configuring for aws-crt-cpp-0.24.0
===>  Performing out-of-source build
/bin/mkdir -p /wrkdirs/usr/ports/devel/aws-crt-cpp/work/.build
-- AWS CRT C++ 0.24.0
-- The CXX compiler identification is Clang 14.0.5
-- The C compiler identification is Clang 14.0.5
<snip>
-- aws-c-cal found target: AWS::crypto
-- crypto Include Dir: /usr/include
-- aws-c-cal found target: AWS::crypto
-- crypto Include Dir: /usr/include
-- S2N found target: AWS::crypto
-- crypto Include Dir: /usr/include
-- S2N found target: AWS::crypto
-- crypto Include Dir: /usr/include
-- aws-c-cal found target: AWS::crypto
-- crypto Include Dir: /usr/include
CMake Error at CMakeLists.txt:317 (aws_add_sanitizers):
  Unknown CMake command "aws_add_sanitizers".


-- Configuring incomplete, errors occurred!
*** Error code 1

Configure fails:

Expected Behavior

configure ok

Current Behavior

configure fails related to CMAkeLists: 317

aws_add_sanitizers(${PROJECT_NAME})

Reproduction Steps

cmake

Possible Solution

No response

Additional Information/Context

No response

aws-crt-cpp version used

0.24.0

Compiler and version used

clang 14.0.5

Operating System and version

FreeBSD 13.2 amd64

[yasminetalby]

Hello @nunotexbsd ,

Could you please provide a little more details on your use case? Specifically the reproduction steps. How did you install and build the SDK?

Did you perform a recursive clone git clone --recursiveor initialize the submodules via git submodule update --init?

Best regards,

Yasmine

[nunotexbsd]

Hello @yasminetalby ,

Build is doing on FreeBSD ports framework (aws-crt-cpp port)and it is a trivial update from 2.23.1 to 2.24.0:
https://people.freebsd.org/~eduardo/logs/aws-crt-cpp/aws-crt-cpp-0.24.0.log

It seems related to 7c15c5b since previous builds are ok.

[nunotexbsd]

@yasminetalby

Comment aws_add_sanitizers fixes build:

--- CMakeLists.txt.orig 2023-10-04 19:28:22 UTC
+++ CMakeLists.txt
@@ -314,7 +314,7 @@ aws_use_package(aws-c-s3)
 aws_use_package(aws-c-event-stream)
 aws_use_package(aws-c-s3)

-aws_add_sanitizers(${PROJECT_NAME})
+#aws_add_sanitizers(${PROJECT_NAME})

 target_link_libraries(${PROJECT_NAME} PUBLIC ${DEP_AWS_LIBS})

https://people.freebsd.org/~eduardo/logs/aws-crt-cpp/aws-crt-cpp-0.24.0_HOTFIX.log

Hope that helps.
Thanks

[thomas-roos]

we (https://github.com/aws4embeddedlinux/meta-aws) can also confirm this issue

[xiazhvera]

Fixed in latest release: https://github.com/awslabs/aws-crt-cpp/releases/tag/v0.24.2

[nunotexbsd]

Thanks for fix!