Using argot:ignore annotations in the taint analysis. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victornicolet
changed the title
victornicolet
changed the title
samarth-aws
previously approved these changes
Oct 25, 2024
analysis/dataflow/state.go
Outdated
| @@ -120,10 +121,20 @@ func NewAnalyzerState(p *ssa.Program, pkgs []*packages.Package, l *config.LogGro | |||
| steps []func(*AnalyzerState)) (*AnalyzerState, error) { | |||
| var allContracts []Contract | |||
|
|
|||
| // Load annotations | |||
| // Load annotations byt scanning all package's syntax | |||
| for _, pkg := range pkgs { | ||
| analysisutil.VisitPackages(pkg, func(p *packages.Package) bool { | ||
| // Don't scan stdlib for annotations! | ||
| if summaries.IsStdPackageName(p.Name) { |
There was a problem hiding this comment.
Should we also avoid scanning dependencies? Not sure how to identify them though
There was a problem hiding this comment.
I'll leave a TODO and make an issue. Based on demand we can figure out how to implement it, but early on it's unlikely the dependencies will have annotations, and scanning is relatively fast compared to all the other analysis steps.
There was a problem hiding this comment.
Issue #102 for tracking this.
victornicolet
force-pushed
the
argot-ignore-annotation
branch
from
9450072
to
24b590c
Compare
samarth-aws
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotating a line with
//argot:ignoresupresses findings on that line for the taint analysis.See
analysis/taint/testdata/annotations/main.gofor an example.