Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(ami): setup-local-disks script fails when called with "none" as argument #2104

Closed
vflaux opened this issue Jan 3, 2025 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@vflaux
Copy link
Contributor

vflaux commented Jan 3, 2025

What happened:
setup-local-disks script fails when called with "none" as argument due to a missing "echo".

sh-4.2$ sudo setup-local-disks none
/bin/setup-local-disks: line 240: disk setup is 'none', nothing to do!: command not found
Exited with error on line 240
sh-4.2$ echo $?
127

if [ "${DISK_SETUP}" = "none" ]; then
"disk setup is 'none', nothing to do!"
exit 0
fi

What you expected to happen:
The error message and exit code 0.

How to reproduce it (as minimally and precisely as possible):

Execute sudo setup-local-disks none from an instance.

Environment:

  • AWS Region: N/A
  • Instance Type(s): N/A
  • Cluster Kubernetes version: v1.30.7-eks-56e63d8
  • Node Kubernetes version: v1.30.4-eks-a737599
  • AMI Version: amazon-eks-node-1.30-v20240924
@vflaux vflaux added the bug Something isn't working label Jan 3, 2025
@cartermckinnon
Copy link
Member

Huh, that’s a weird one! Thanks for the report, feel free to open a PR for things like this if you find them 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants