Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The multiline pattern of awslogs shim logger cannot log the last matched line in e2e tests #78

Open
ningziwen opened this issue Sep 28, 2023 · 0 comments

Comments

@ningziwen
Copy link
Member

During my test against awslogs shim logger, the last matched line cannot be logged when multiline pattern is set.

For example, when the multiline pattern is ^INFO, and the log printed by container is

INFO a
INFO b
INFO c

Only INFO a and INFO b can be passed to awslogs.

This may be caused by test set up or the bug of the feature itself.

Need more investigation. Some potential directions to investigate:

  • Try to reproduce with Nerdctl by specifying the shim logger binary path.
  • The shim logger depends on the log drivers in Moby. So we can try to reproduce by Docker with its native awslogs driver.
  • The logic here seems processing event first with buffer and then append to the buffer. So it is possible that the last line's content is attached to the buffer finally but does not have chance to be processed.
  • The current awslogs test infra uses AWS local stack , so may have feature gaps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant